generated from bazel-contrib/rules-template
-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add comment ignores to example #314
Open
SpencerC
wants to merge
12
commits into
aspect-build:main
Choose a base branch
from
SpencerC:cmt_ignore
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+25
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeagle
reviewed
Jul 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
neat thanks!
FYI @perezd - I suspect a lot of Bazelers will use Buf via this ruleset, and maybe you'd like to reduce the ambition of rules_buf if you can avoid maintaining formatting&linting support
Yeah, we would like to not maintain that. Sounds good to us! |
alexeagle
approved these changes
Jul 9, 2024
Also fix integration test golden line
alexeagle
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
buf's
allow_comment_ignores
functionality does not work out of the box. It requires the bazel--experimental_proto_descriptor_sets_include_source_info
to work. See: bufbuild/rules_buf#64 (comment)Many of these changes mirror bufbuild/rules_buf#80, and I suspect adding them here as well will save a lot of folks needing to dive a layer down to figure out how to configure buf correctly.
Changes are visible to end-users: yes
Test plan
example
directory is tested manually. To test, I suggest modifying the items inexample/buf.yaml
and the comment ignores inexample/src/file.proto
and verifying they behave as expected.