fix: make //js/private:enable_runfiles explicitly have //visibility:public
#301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y:public` This is a direct dependency of all `js_binary()` targets and is currently `//visibility:public` by default, however this behavior is changing and can be opted in early via the [`--incompatible_config_setting_private_default_visibility`](https://bazel.build/reference/command-line-reference#flag--incompatible_config_setting_private_default_visibility) flag. Making this target explicitly public passes the build with that flag.
dgp1130
added a commit
to dgp1130/rules_prerender
that referenced
this pull request
Jul 20, 2022
… it does not work with `@aspect_rules_js`. Once aspect-build/rules_js#301 lands, this can be re-enabled.
|
|
jbedard
approved these changes
Jul 20, 2022
dgp1130
added a commit
to dgp1130/rules_prerender
that referenced
this pull request
Aug 2, 2022
… for `--config incompatible` builds. Refs #48. Since `@aspect_rules_js` has been updated to include aspect-build/rules_js#301, we can now re-enable this flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a direct dependency of all
js_binary()targets and is currently//visibility:publicby default, however this behavior is changing and can be opted in early via the--incompatible_config_setting_private_default_visibilityflag. Making this target explicitly public passes the build with that flag.See this CI failure using the
--incompatible_*flag.