generated from bazel-contrib/rules-template
-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: jasmine_test doesn't work if type = "module" in package.json #33
Labels
bug
Something isn't working
Comments
dgp1130
added a commit
to dgp1130/rules_prerender
that referenced
this issue
Mar 1, 2023
dgp1130
added a commit
to dgp1130/rules_prerender
that referenced
this issue
Mar 1, 2023
dgp1130
added a commit
to dgp1130/rules_prerender
that referenced
this issue
Mar 1, 2023
dgp1130
added a commit
to dgp1130/rules_prerender
that referenced
this issue
Mar 1, 2023
dgp1130
added a commit
to dgp1130/rules_prerender
that referenced
this issue
Mar 1, 2023
dgp1130
added a commit
to dgp1130/rules_prerender
that referenced
this issue
Mar 1, 2023
This fixes aspect-build/rules_jasmine#33 and adds ESM support. I've sent a PR in aspect-build/rules_jasmine#41 to apply the fix upstream, but for now a patch will have to do.
dgp1130
added a commit
to dgp1130/rules_prerender
that referenced
this issue
Mar 4, 2023
This fixes aspect-build/rules_jasmine#33 and adds ESM support. I've sent a PR in aspect-build/rules_jasmine#41 to apply the fix upstream, but for now a patch will have to do.
dgp1130
added a commit
to dgp1130/rules_prerender
that referenced
this issue
Mar 4, 2023
This fixes aspect-build/rules_jasmine#33 and adds ESM support. I've sent a PR in aspect-build/rules_jasmine#41 to apply the fix upstream, but for now a patch will have to do.
dgp1130
added a commit
to dgp1130/rules_prerender
that referenced
this issue
Mar 4, 2023
This fixes aspect-build/rules_jasmine#33 and adds ESM support. I've sent a PR in aspect-build/rules_jasmine#41 to apply the fix upstream, but for now a patch will have to do.
dgp1130
added a commit
to dgp1130/rules_prerender
that referenced
this issue
Mar 4, 2023
Refs #33. This fixes aspect-build/rules_jasmine#33 and adds ESM support. I've sent a PR in aspect-build/rules_jasmine#41 to apply the fix upstream, but for now a patch will have to do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What happened?
I had to change type = "module" to type = "commonjs" to get the jasmine test to work properly: gonzojive/gTile@8b4ecde
... I can give error details later
Version
Development (host) and target OS/architectures:
Output of
bazel --version
:Version of the Aspect rules, or other relevant rules from your
WORKSPACE
orMODULE.bazel
file:Language(s) and/or frameworks involved:
How to reproduce
Any other information?
I think runner.js could be renamed runner.cjs, and this problem would be averted.
Fund our work
The text was updated successfully, but these errors were encountered: