Add Qwik example #359
Add Qwik example #359
Conversation
|
|
FYI @shairez in case you missed Bazel 😉 |
| alt="Qwik Logo" | ||
| width={400} | ||
| height={147} | ||
| src="https://cdn.builder.io/api/v1/image/assets%2FYJIGb4i01jvw0SRdL5Bt%2F667ab6c2283d4c4d878fb9083aacc10f" |
There was a problem hiding this comment.
seems like the (very) old logo of Qwik.
I guess this starter has been generated from an old version of Qwik?
There was a problem hiding this comment.
This is the logo in the library template at the moment: https://github.com/QwikDev/qwik/blob/main/starters/apps/library/src/components/logo/logo.tsx
I can replace it with what you are using on the docs or something else if you prefer? (the docs are not using an SVG exactly, but I think I can make it work). Also do you need this change in the Qwik repo as well?
The docs logo I could find: https://github.com/QwikDev/qwik/blob/main/packages/docs/src/components/svgs/qwik-logo.tsx
There was a problem hiding this comment.
@Mivr yeah good point, we need to update it, we'll do thanks!
|
Great job guys! |
Added a simple Qwik example as to: #347
The app and lib are both plain generation from the examples provided by Qwik.
The app is connected to the lib with a link in the monorepo and uses the library components.
I have not added tests yet, from what I have seen they are just using vite test for the front end tests, I suppose a UI test is needed? I am asking as the tests will be the same as a generic Vitest on the build side at least.
The dev cycle is slow at the moment or not working OK, due to: vitejs/vite#8619
There is a start command that works, but is slow (>5s per update).
Also there is a fast (<1s) command "devserver" that works well only for 1 library update.
For this to be resolved it seems some work on Vite is needed.
Changes are visible to end-users: no
Test plan