Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process: sync commits from Aspect-internal silo #765

Merged
merged 3 commits into from
Oct 29, 2024

Conversation

Copy link

aspect-workflows bot commented Oct 29, 2024

Test

106 test targets passed

Targets
//gazelle/js:declare_module_types_test [k8-fastbuild]                   607ms
//gazelle/js:dynamic_import_test [k8-fastbuild]                         424ms
//gazelle/js:gazelle_disable_conflict_test [k8-fastbuild]               505ms
//gazelle/js:gazelle_disable_test [k8-fastbuild]                        358ms
//gazelle/js:gazelle_exclude_directive_test [k8-fastbuild]              562ms
//gazelle/js:gazelle_generate_build_test [k8-fastbuild]                 440ms
//gazelle/js:gazelle_generation_mode_legacy_test [k8-fastbuild]         425ms
//gazelle/js:gazelle_generation_mode_test [k8-fastbuild]                407ms
//gazelle/js:gazelle_ignore_directive_test [k8-fastbuild]               347ms
//gazelle/js:gazelle_keep_test [k8-fastbuild]                           669ms
//gazelle/js:groups_add_remove_rules_test [k8-fastbuild]                421ms
//gazelle/js:groups_configs_test [k8-fastbuild]                         1s
//gazelle/js:groups_deps_test [k8-fastbuild]                            425ms
//gazelle/js:groups_simple_files_test [k8-fastbuild]                    441ms
//gazelle/js:ignore_config_files_test [k8-fastbuild]                    1s
//gazelle/js:ignore_import_directive_test [k8-fastbuild]                1s
//gazelle/js:js_test [k8-fastbuild]                                     533ms
//gazelle/js:node_native_test [k8-fastbuild]                            436ms
//gazelle/js:npm_changed_deps_test [k8-fastbuild]                       594ms
//gazelle/js:npm_link_all_packages_test [k8-fastbuild]                  242ms
//gazelle/js:npm_package_deps_lib_test [k8-fastbuild]                   713ms
//gazelle/js:npm_package_deps_test [k8-fastbuild]                       371ms
//gazelle/js:npm_package_deps_tsconfig_test [k8-fastbuild]              559ms
//gazelle/js:npm_package_lib_target_name_test [k8-fastbuild]            692ms
//gazelle/js:npm_package_target_enabled_test [k8-fastbuild]             496ms
//gazelle/js:npm_package_target_name_test [k8-fastbuild]                445ms
//gazelle/js:npm_package_target_referenced_test [k8-fastbuild]          1s
//gazelle/js:npm_simple_deps_cjs_test [k8-fastbuild]                    366ms
//gazelle/js:npm_simple_deps_test [k8-fastbuild]                        716ms
//gazelle/js:npm_types_package_test [k8-fastbuild]                      317ms
//gazelle/js:parse_errors_test [k8-fastbuild]                           399ms
//gazelle/js:pnpm_project_refs_lock5_test [k8-fastbuild]                552ms
//gazelle/js:pnpm_project_refs_lock6_test [k8-fastbuild]                552ms
//gazelle/js:pnpm_project_refs_lock9_test [k8-fastbuild]                240ms
//gazelle/js:pnpm_workspace_rerooted_test [k8-fastbuild]                352ms
//gazelle/js:pnpm_workspace_test [k8-fastbuild]                         451ms
//gazelle/js:resolve_directive_test [k8-fastbuild]                      255ms
//gazelle/js:resolve_order_test [k8-fastbuild]                          560ms
//gazelle/js:rules_conflicting_name_mapped_kind_test [k8-fastbuild]     504ms
//gazelle/js:rules_conflicting_name_nojs_test [k8-fastbuild]            288ms
//gazelle/js:rules_conflicting_name_test [k8-fastbuild]                 1s
//gazelle/js:rules_ordering_test [k8-fastbuild]                         325ms
//gazelle/js:simple_dts_only_test [k8-fastbuild]                        325ms
//gazelle/js:simple_empty_test [k8-fastbuild]                           585ms
//gazelle/js:simple_file_exts_test [k8-fastbuild]                       2s
//gazelle/js:simple_file_test [k8-fastbuild]                            390ms
//gazelle/js:simple_globs_keep_test [k8-fastbuild]                      705ms
//gazelle/js:simple_globs_test [k8-fastbuild]                           1s
//gazelle/js:simple_import_disabled_test [k8-fastbuild]                 583ms
//gazelle/js:simple_import_generated_test [k8-fastbuild]                1s
//gazelle/js:simple_imports_cjs_test [k8-fastbuild]                     823ms
//gazelle/js:simple_imports_test [k8-fastbuild]                         925ms
//gazelle/js:simple_json_import_test [k8-fastbuild]                     422ms
//gazelle/js:simple_new_file_test [k8-fastbuild]                        285ms
//gazelle/js:tests_initial_test [k8-fastbuild]                          454ms
//gazelle/js:tests_new_test [k8-fastbuild]                              410ms
//gazelle/js:tests_nolib_test [k8-fastbuild]                            322ms
//gazelle/js:tests_simple_test [k8-fastbuild]                           182ms
//gazelle/js:tests_subdir_test [k8-fastbuild]                           334ms
//gazelle/js:tests_subproject_test [k8-fastbuild]                       462ms
//gazelle/js:ts_proto_library_test [k8-fastbuild]                       1s
//gazelle/js:tsconfig_attrs_inherited_test [k8-fastbuild]               722ms
//gazelle/js:tsconfig_baseurl_test [k8-fastbuild]                       1s
//gazelle/js:tsconfig_deps_test [k8-fastbuild]                          897ms
//gazelle/js:tsconfig_invalid_test [k8-fastbuild]                       541ms
//gazelle/js:tsconfig_jsx_test [k8-fastbuild]                           1s
//gazelle/js:tsconfig_lax_json_test [k8-fastbuild]                      428ms
//gazelle/js:tsconfig_manual_test [k8-fastbuild]                        646ms
//gazelle/js:tsconfig_nomore_configs_test [k8-fastbuild]                320ms
//gazelle/js:tsconfig_outdir_test [k8-fastbuild]                        1s
//gazelle/js:tsconfig_paths_test [k8-fastbuild]                         725ms
//gazelle/js:tsconfig_pnpm_ref_rerooted_test [k8-fastbuild]             322ms
//gazelle/js:tsconfig_pnpm_ref_test [k8-fastbuild]                      252ms
//gazelle/js:tsconfig_rootdir_test [k8-fastbuild]                       330ms
//gazelle/js:tsconfig_rootdirs_test [k8-fastbuild]                      355ms
//gazelle/js:tsconfig_tslib_test [k8-fastbuild]                         368ms
//gazelle/js:validate_import_statements_off_test [k8-fastbuild]         628ms
//gazelle/js:validate_import_statements_test [k8-fastbuild]             187ms
//gazelle/js:validate_import_statements_warn_test [k8-fastbuild]        934ms
//gazelle/js:visibility_test [k8-fastbuild]                             682ms
//gazelle/kotlin:bin_test [k8-fastbuild]                                543ms
//gazelle/kotlin:gazelle_disable_conflict_test [k8-fastbuild]           601ms
//gazelle/kotlin:gazelle_disable_test [k8-fastbuild]                    481ms
//gazelle/kotlin:gazelle_exclude_directive_test [k8-fastbuild]          542ms
//gazelle/kotlin:ignore_config_files_test [k8-fastbuild]                639ms
//gazelle/kotlin:local_deps_test [k8-fastbuild]                         712ms
//gazelle/kotlin:native_deps_test [k8-fastbuild]                        698ms
//gazelle/kotlin:rules_conflicting_name_mapped_kind_test [k8-fastbuild] 326ms
//gazelle/kotlin:rules_conflicting_name_test [k8-fastbuild]             182ms
//gazelle/kotlin:rules_jvm-maven_test [k8-fastbuild]                    293ms
//gazelle/kotlin:simple_file_test [k8-fastbuild]                        648ms
//gazelle/kotlin:unknown_imports_test [k8-fastbuild]                    804ms
//integration_tests/aspect:configure_test [k8-fastbuild]                47s
//integration_tests/aspect:flags_test [k8-fastbuild]                    2m 10s
//integration_tests/aspect:help_test [k8-fastbuild]                     59s
//integration_tests/aspect:info_test [k8-fastbuild]                     25s
//integration_tests/aspect:init_test [k8-fastbuild]                     51s
//integration_tests/aspect:lint_test [k8-fastbuild]                     1m 41s
//integration_tests/aspect:reenter_test [k8-fastbuild]                  43s
//integration_tests/aspect:version_test [k8-fastbuild]                  32s
+ 6 other targets

Total test execution time was 9m 6s. 102 tests (49.0%) were fully cached saving 24s.


Buildifier      Format

jbedard and others added 3 commits October 29, 2024 10:16
We've gotten feedback from multiple customers that this is surprising.
It also doesn't work well with flags that query accepts but cquery does
not.

---

### Changes are visible to end-users: no

### Test plan

- Covered by existing test cases

GitOrigin-RevId: 0c1981fe30637e9d355bd3fbd5bc6db5099dcc8f
Mainly in prep for moving rules_go to MODULE which brings in
[email protected] while we were at ~0.38

---

### Changes are visible to end-users: no

### Test plan

- Covered by existing test cases

GitOrigin-RevId: c8d4d010223bc37cd60cc497b955bd97eba014c6
@jbedard jbedard merged commit f51910f into main Oct 29, 2024
11 checks passed
@jbedard jbedard deleted the 788EA150BB0FAAB4A3FF81F26DCBE189 branch October 29, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants