-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
process: sync commits from Aspect-internal silo #765
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've gotten feedback from multiple customers that this is surprising. It also doesn't work well with flags that query accepts but cquery does not. --- ### Changes are visible to end-users: no ### Test plan - Covered by existing test cases GitOrigin-RevId: 0c1981fe30637e9d355bd3fbd5bc6db5099dcc8f
Mainly in prep for moving rules_go to MODULE which brings in [email protected] while we were at ~0.38 --- ### Changes are visible to end-users: no ### Test plan - Covered by existing test cases GitOrigin-RevId: c8d4d010223bc37cd60cc497b955bd97eba014c6
jbedard
force-pushed
the
788EA150BB0FAAB4A3FF81F26DCBE189
branch
from
October 29, 2024 17:20
fcb0332
to
62f8e63
Compare
gregmagolan
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit range https://github.com/aspect-build/silo/compare/82135c3f6342ea0893d5701b6bb4cfc451e6fe0b..94a01922edd9ae69532fbf75105470075327d756