Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: don't depend on system patch for go_googleapis dep #493

Merged
merged 1 commit into from
Jul 23, 2023
Merged

ci: don't depend on system patch for go_googleapis dep #493

merged 1 commit into from
Jul 23, 2023

Conversation

gregmagolan
Copy link
Member

@gregmagolan gregmagolan commented Jul 23, 2023 •
edited
Loading

Same as bazel-contrib/rules_go#3617.

Type of change

  • Chore (any other change that doesn't affect source or test files, such as configuration)

Test plan

  • Manual testing; please provide instructions so we can reproduce:

Will remove patch from the PATH on Amazon Linux 2 CI workers and observe that warming is still green: https://buildkite.com/aspect/aspect-cli-warming/builds/217#018984b7-ed55-4234-9804-e29985609a76

@gregmagolan gregmagolan merged commit 787519d into main Jul 23, 2023
6 checks passed
@gregmagolan gregmagolan deleted the fix_system_patch_dep branch July 23, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kormide kormide kormide approved these changes

@alexeagle alexeagle Awaiting requested review from alexeagle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gregmagolan @kormide