Add some must_use warnings #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no good reason to create a Context object but not set any expectations. And when the "nightly" feature is off, there's no good reason to create an expectation but not set its return value. Warn the user if he does one of those things. Suggested by @ArekPiekarz
asomers
added a commit
that referenced
this pull request
Nov 2, 2019
Pull request #37 added some must_use warnings conditionalized on the "nightly" feature. However, because proc macros are unhygienic, the warnings were actually conditionalized on the instantiating crate's nightly feature, not on mockall_derive's nightly feature. I didn't notice at the time because Mockall _also_ has a nightly feature, and so does the only crate of mine that uses Mockall. Fix the hygiene errors, and rename mockall_derive's feature to "nightly_derive", which will help to catch similar errors in the future.
asomers
added a commit
that referenced
this pull request
Nov 2, 2019
Pull request #37 added some must_use warnings conditionalized on the "nightly" feature. However, because proc macros are unhygienic, the warnings were actually conditionalized on the instantiating crate's nightly feature, not on mockall_derive's nightly feature. I didn't notice at the time because Mockall _also_ has a nightly feature, and so does the only crate of mine that uses Mockall. Fix the hygiene errors, and rename mockall_derive's feature to "nightly_derive", which will help to catch similar errors in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no good reason to create a Context object but not set any
expectations. And when the "nightly" feature is off, there's no good
reason to create an expectation but not set its return value. Warn the
user if he does one of those things.
Suggested by @ArekPiekarz