Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build when #![deny(missing_docs)] is in force #107

Merged
merged 4 commits into from
Mar 13, 2020
Merged

Conversation

asomers
Copy link
Owner

@asomers asomers commented Mar 12, 2020

Also, add mor examples to mockall_examples

@asomers
Copy link
Owner Author

asomers commented Mar 12, 2020

@codehearts everything should build fine with #[deny(missing_docs)] now. Could you please check it? I tried to add useful docs everywhere. But there were a few modules that aren't intended for direct user interaction, yet can't be hidden because they contain things that are intended for user interaction. For those I simply allowed missing docs.

@asomers
Copy link
Owner Author

asomers commented Mar 13, 2020

The build failure is due to a stricter check for uninitialized data in the latest nightly compiler. I'll fix it in a separate PR.

@asomers asomers force-pushed the deny_missing_docs branch from e6daee1 to 61e0e70 Compare March 13, 2020 00:37
@codehearts
Copy link

This resolved it for me, thank you so much for making time for this!

@asomers
Copy link
Owner Author

asomers commented Mar 13, 2020

Thanks for reporting it. And happy hacking!

@asomers asomers merged commit 99a3877 into master Mar 13, 2020
@asomers asomers deleted the deny_missing_docs branch March 13, 2020 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants