Add support for custom configuration #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This follows the client-go docs tutorial https://github.com/kubernetes/client-go/blob/master/tools/clientcmd/doc.go
|
Could you resolve the conflicts with this PR |
asobti
requested changes
Nov 9, 2017
kubernetes/kubernetes.go
Outdated
| } | ||
|
|
||
| if apiserverHost, override := cfg.ClusterAPIServerHost(); override { | ||
| fmt.Printf("API server host overriden to: %s\n", apiserverHost) |
There was a problem hiding this comment.
This file is still using fmt (pre-glog commit) but is no longer importing the fmt package.
Here are the errors I'm seeing:
GOOS=linux GOARCH=amd64 CGO_ENABLED=0 go build -o kube-monkey
# github.com/asobti/kube-monkey/kubernetes
kubernetes/kubernetes.go:16:22: undefined: os
kubernetes/kubernetes.go:31:37: undefined: fmt
kubernetes/kubernetes.go:41:37: undefined: fmt
kubernetes/kubernetes.go:47:3: undefined: fmt
kubernetes/kubernetes.go:48:3: undefined: config
There was a problem hiding this comment.
Ahh yes, I was on the go and unable to integrate the glog changes. It should now be using it glog style.
|
I developed this branch separately from glog Resolved the conflicts correctly and verified the build locally :) ready for review |
This was referenced Jan 3, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If someone has a cluster that isn't easily configured with InClusterConfig, this allows them to use a custom config. This does not change the user experience for normal users.