Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timezone is not working on the configmap #23

Closed
cfontes opened this issue Dec 7, 2017 · 5 comments
Closed

Timezone is not working on the configmap #23

cfontes opened this issue Dec 7, 2017 · 5 comments

Comments

@cfontes
Copy link

cfontes commented Dec 7, 2017

I am trying to set the internal timezone of the scheduler for my own like this

  apiVersion: v1
  kind: ConfigMap
  metadata:
    name: kube-monkey-config-map
    namespace: kube-system
  data:
    config.toml: |
      [kubemonkey]
      run_hour = 8
      start_hour = 10
      end_hour = 16
      blacklisted_namespaces = ["kube-system"]
      timezone = "Europe/Amsterdam"

As I saw in the code that it is there, but it is not working...

It's always like this

I1207 15:47:29.649440 1 kubemonkey.go:26] Generating next schedule at 2017-12-07 08:00:00 -0800 PST

So time is in time format but the scheduler is not

Changing the default in the code and recompiling it woks so that is what I did here, but would be nice to have it documented or if it's a bug fixed.

Thanks, awesome work!

@ChristofferNicklassonLenswayGroup

We where forced to do the same solution.

@caipre
Copy link

caipre commented Dec 21, 2017

@cfontes @ChristofferNicklassonLenswayGroup the key is time_zone:

// The timezone to use when scheduling Pod terminations
// Type: string
// Default: America/Los_Angeles
Timezone = "kubemonkey.time_zone"

Aergonus added a commit to Aergonus/kube-monkey that referenced this issue Dec 27, 2017
Allow people to copy pasta ;)
asobti#23
Aergonus added a commit to Aergonus/kube-monkey that referenced this issue Jan 2, 2018
standardized variables to loc
added timezone for debugging printing
specified format printout for schedule
addresses asobti#21 and asobti#23
@Aergonus Aergonus mentioned this issue Jan 2, 2018
@ChristofferNicklassonLenswayGroup
Copy link

ChristofferNicklassonLenswayGroup commented Feb 12, 2018

i just pulled latest and still it prints PST.
skarmbild fran 2018-02-12 10-07-20

Edit:
Did a clean install and then it worked.

@sudarshntn
Copy link

The values given in this page works as I have used the Asia values from here and it worked. Just a FYI.
https://golang.org/src/time/zoneinfo_abbrs_windows.go

@asobti
Copy link
Owner

asobti commented Mar 15, 2018

Does not appear to be an issue anymore. Closing.

@asobti asobti closed this as completed Mar 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants