Resolve PHP warnings

asmecher · Oct 3, 2019 · 3877b85 · 3877b85
1 parent 3f0fd99
commit 3877b85
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 4 deletions.
diff --git a/classes/security/authorization/DataObjectRequiredPolicy.inc.php b/classes/security/authorization/DataObjectRequiredPolicy.inc.php
@@ -91,7 +91,9 @@ function dataObjectEffect() {
 	}
 
 	/**
-	 * Identifies a submission id in the request.
+	 * Identifies a data object id in the request.
+	 * @param $lookOnlyByParameterName boolean True iff page router
+	 *  requests should only look for named parameters.
 	 * @return integer|false returns false if no valid submission id could be found.
 	 */
 	function getDataObjectId($lookOnlyByParameterName = false) {

diff --git a/classes/services/PKPUserService.inc.php b/classes/services/PKPUserService.inc.php
@@ -71,7 +71,7 @@ public function getMany($args = array()) {
 	public function getMax($args = array()) {
 		$userListQB = $this->_getQueryBuilder($args);
 		$countQO = $userListQB->countOnly()->get();
-		$countRange = new DBResultRange($args['count'], 1);
+		$countRange = new DBResultRange($args['count']??null, 1);
 		$userDao = DAORegistry::getDAO('UserDAO');
 		$countResult = $userDao->retrieveRange($countQO->toSql(), $countQO->getBindings(), $countRange);
 		$countQueryResults = new DAOResultFactory($countResult, $userDao, '_returnUserFromRowWithData');

diff --git a/classes/submission/reviewAssignment/ReviewAssignment.inc.php b/classes/submission/reviewAssignment/ReviewAssignment.inc.php
@@ -653,7 +653,7 @@ function getWeeksDue() {
 	 * (Includes default '' => "Choose One" string.)
 	 * @return array recommendation => localeString
 	 */
-	function getReviewerRecommendationOptions() {
+	static function getReviewerRecommendationOptions() {
 
 		static $reviewerRecommendationOptions = array(
 				'' => 'common.chooseOne',

diff --git a/classes/submission/reviewer/form/ReviewerReviewStep3Form.inc.php b/classes/submission/reviewer/form/ReviewerReviewStep3Form.inc.php
@@ -246,7 +246,7 @@ function execute() {
 
 		$userDao = DAORegistry::getDAO('UserDAO');
 		$reviewer = $userDao->getById($reviewAssignment->getReviewerId());
-		$request = Application::getRequest();
+		$request = Application::get()->getRequest();
 		SubmissionLog::logEvent(
 			$request,
 			$submission,