Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helm-git): multiple fixes #262

Closed
wants to merge 4 commits into from

Conversation

GMartinez-Sisti
Copy link

@GMartinez-Sisti GMartinez-Sisti commented Sep 1, 2023

Why

I was trying this awesome plugin, but found some issues with the way I wanted to use it. I want to be able to use packaged helm charts from a branch, the charts and index.yaml might be in the root folder of the repository and this was not allowed.

Also had to set the url to git+ssh://[email protected]/org/repository/path/package-x.x.x.tgz?ref=branch&sparse=0&depupdate=1&package=0 in index.yaml on all the packages for this work.

What

  1. add trace: makes it easier to troubleshoot
  2. allow using repository root folder: there was an assumption that there would be a path with @
  3. ensure we have the latest from ref: when using HELM_GIT_REPO_CACHE the branch wouldn't be updated, probably the initial intention was to only use tags
  4. lint file: shellcheck

@GMartinez-Sisti GMartinez-Sisti changed the title Multiple Fixes fix(helm-git): multiple fixes Sep 1, 2023
@aslafy-z
Copy link
Owner

aslafy-z commented Sep 1, 2023

Thank you for the contribution 🙏
I'm currently on vacation, I will take a look once back in a few days.

@GMartinez-Sisti
Copy link
Author

Thank you for the contribution 🙏
I'm currently on vacation, I will take a look once back in a few days.

Thank you for the feedback. Enjoy your vacations! 🌴

@GMartinez-Sisti
Copy link
Author

Ping 👼

@aslafy-z
Copy link
Owner

Hey there! Sorry for the long delay and thank you for pinging again!
This looks good! Can you please add a test to validate that we can now refer to the root without using @ and that it still works with the old way?
Thank you!

@aslafy-z
Copy link
Owner

@GMartinez-Sisti hey, I would like to merge this PR, let me know if you're able to do the required change. I may take the PR over if not.

@GMartinez-Sisti
Copy link
Author

@GMartinez-Sisti hey, I would like to merge this PR, let me know if you're able to do the required change. I may take the PR over if not.

Hi @aslafy-z, sorry for not picking this up earlier! I already lost context for this PR 😬 Feel free to take it 😄

@aslafy-z
Copy link
Owner

aslafy-z commented Apr 11, 2024

add trace: makes it easier to troubleshoot

Ported with #266

allow using repository root folder: there was an assumption that there would be a path with @

See #267, not sure how it would behave with GitLab multi level hierarchy for instance. Will keep as a draft until I find a solution. Implemented with #284.

ensure we have the latest from ref: when using HELM_GIT_REPO_CACHE the branch wouldn't be updated, probably the initial intention was to only use tags

Wouldn't this defeat the cache? What would be the right time to refresh for you? Tracked at #292.

lint file: shellcheck

Ported with #268. It would be a nice to have as a pre-commit step/in the ci, issue at #288.

Edit 2024/07/09: Updated

@aslafy-z aslafy-z mentioned this pull request Jul 9, 2024
@aslafy-z
Copy link
Owner

aslafy-z commented Jul 9, 2024

Thank you for your work on this PR. Every bits are now either implemented or tracked within new issues. See my previous comment: #262 (comment).

@aslafy-z aslafy-z closed this Jul 9, 2024
@GMartinez-Sisti GMartinez-Sisti deleted the fixes branch July 9, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants