fix: Fix fetching annotated tags #226
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hmm, I wonder why tests pass locally, I will check |
|
@aslafy-z is the github action ok? |
aslafy-z
force-pushed
the
fix-annotated-tags
branch
from
dc7fd2c
to
e286652
Compare
aslafy-z
force-pushed
the
fix-annotated-tags
branch
from
e286652
to
5d81754
Compare
|
@arkaitzj I fixed the CI! Can you please implement some tests for it? |
|
@arkaitzj Any update on this ? |
|
Can you please add tests to validate the functionality? Thank you |
|
bump |
|
@maxime1907 This new functionality needs integration tests. Can you write some? I can help if needed. |
|
Should be fixed with #265 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered a bug while fetching annotated tags where we cannot do a standard fetch Tag