Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Cache git repos and/or helm charts #222

Merged
merged 11 commits into from
Nov 7, 2022
Merged

Conversation

arkaitzj
Copy link
Contributor

@arkaitzj arkaitzj commented Nov 6, 2022

While using helm-git in a manifest generation pipeline I have noticed a lot of redundant git fetches, helm indexes and helm packages.

With this PR, currently using it, 2 new behaviours become available.

  • Cache git repos, by setting HELM_GIT_REPO_CACHE env to an existing folder it ensures repos are only fetched once per ref, it can also be used for offline generation by copying the cache as an artifact
  • Cache helm charts, by setting HELM_GIT_CHART_CACHE env to an existing folder it ensures charts are only generated once, this speeds up manifest generating pipelines by a lot if git provided charts are reused in many places.

Even just rm -rf caches && ./generate_manifests is orders of magnitude faster for us when enabling both caches

@arkaitzj arkaitzj changed the title Cache git repos and/or helm charts + tests feat: Cache git repos and/or helm charts + tests Nov 6, 2022
helm-git-plugin.sh Outdated Show resolved Hide resolved
helm-git-plugin.sh Outdated Show resolved Hide resolved
@aslafy-z aslafy-z changed the title feat: Cache git repos and/or helm charts + tests feat: Cache git repos and/or helm charts Nov 7, 2022
@aslafy-z aslafy-z merged commit bafe61e into aslafy-z:master Nov 7, 2022
@aslafy-z
Copy link
Owner

aslafy-z commented Nov 7, 2022

🎉 This PR is included in version 0.14.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aslafy-z aslafy-z added the released This issue/pull request has been released. label Nov 7, 2022
@aslafy-z
Copy link
Owner

aslafy-z commented Nov 7, 2022

Thank you @arkaitzj for this awesome addition! Looking forward to review your next contributions 💯

@arkaitzj
Copy link
Contributor Author

arkaitzj commented Nov 7, 2022

my pleasure! thanks for speedy iterations! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants