feat: add support for helm compatible binaries like werf

[himanshu-garg-razorpay]

Q	A
Bug fix?	yes
New feature?	no
API breaks?	no
Deprecations?	no
Related tickets	fixes #210
License	Apache 2.0

What's in this PR?

Removes the code checking for the "validity" of the helm binary provided.
It was a brittle mechanism grepping for the current documentation on calling help.
This breaks not just for different helm compatible binaries like werf but also if helm itself changes its documentation.
The "validity" of a binary is hard to define in a way that allows interop with all future helm compatible binaries.
Also, I don't think we'll introduce any bugs by not checking this because when someone passes an "invalid" binary it will just not work. On the other hand, if it works, who are we to say it's not a valid binary. If it walks like a duck, quacks like a duck, it is a duck.

Checklist

• Code meets the Developer Guide
• User guide and development docs updated (if needed)
• Related Helm chart(s) updated (if needed)

[aslafy-z]

Thank you for the contribution. I think you'll have to change all references from "$HELM_BIN" to $HELM_BIN, i.e. Remove the quotes for it to work with HELM_BIN="werf helm".
Can you add a test with a mocking script like:

#!/bin/sh
exec $@

and call it with HELM_BIN="/path/to/script.sh helm" in the test to ensure helm-git keeps support for multi word 'executables'

[himanshu-garg-razorpay]

@aslafy-z for werf, you don't use HELM_BIN="werf helm", instead you use HELM_BIN="werf" (with some environment variable asking werf to maintain helm compatibility) and for any other helm compatible binary, single worded usage should be enough as anything multi-worded can be trivially converted to a single word option (using a script)

And yes I understand that there might be a use-case for multi-worded executables especially to not have to write a script, however, that's not really what I'm trying to target here, primarily because it increases my test surface (what about HELM_BIN='do_x && helm') as you rightly pointed out.

I'll be happy to create a separate issue for multi word support in HELM_BIN to look for use-cases in the community.

[aslafy-z]

@himanshu-garg-razorpay lgtm! Can you please rebase your PR before I merge it? Thank you

[himanshu-garg-razorpay]

@himanshu-garg-razorpay lgtm! Can you please rebase your PR before I merge it? Thank you

@aslafy-z Done. Please go ahead.

[himanshu-garg-razorpay]

@aslafy-z thanks for the approval and running the workflows. The workflow checks have passed. Shall we merge this now..?

[himanshu-garg-razorpay]

@aslafy-z if there's nothing else already planned to be released (not seeing any open PRs), please create a new release so that we can start deprecating our internal fork

[aslafy-z]

🎉 This PR is included in version 0.13.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[aslafy-z]

@himanshu-garg-razorpay the release pipeline was stuck for some reason. It should be good by now 🚀