Skip to content
This repository has been archived by the owner on Feb 16, 2020. It is now read-only.

Fix check for data errors in binance response #1674

Merged
merged 1 commit into from
Jan 13, 2018
Merged

Fix check for data errors in binance response #1674

merged 1 commit into from
Jan 13, 2018

Conversation

cmroche
Copy link
Contributor

@cmroche cmroche commented Jan 12, 2018

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Bugfix

  • What is the current behavior? (You can also link to an open issue here)

Could crash on test for body.code in Binance api response when the response is empty.

  • What is the new behavior (if this is a feature change)?

Check for the empty body.

  • Other information:

@cmroche
Copy link
Contributor Author

cmroche commented Jan 12, 2018

Should fix #1673

@storshun storshun mentioned this pull request Jan 13, 2018
Closed
@ansonphong ansonphong mentioned this pull request Jan 13, 2018
Closed
@askmike
Copy link
Owner

askmike commented Jan 13, 2018

👍

@askmike askmike merged commit d6c5188 into askmike:develop Jan 13, 2018
@askmike askmike mentioned this pull request Jan 13, 2018
Merged
@cmroche cmroche deleted the binance branch February 19, 2018 23:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmroche @askmike