This repository has been archived by the owner on Feb 16, 2020. It is now read-only.
Fix typos in tradebot doc #1464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
askmike
suggested changes
Dec 13, 2017
docs/commandline/tradebot.md
Outdated
| @@ -6,11 +6,11 @@ You can set Gekko up as a tradebot, this will instruct Gekko to: | |||
| - Run a strategy (in semi-realtime) over live market data. | |||
| - Automatically create buy/sell orders based on signals coming from the strategy. | |||
|
|
|||
| *As with everything in Gekko, the tradebot will make decisions based on the by YOU selected/configured/created strategy. If you end up losing money you have no one to blame but yourself.* | |||
| *As with everything in Gekko, the tradebot will make decisions based on the selected/configured/created strategy. If you end up losing money, you have no one to blame but yourself.* | |||
There was a problem hiding this comment.
I think the by YOU is an emphasis that we shouldn't remove. If the sentence structure is currently wrong, can we fix it instead of removing this?
There was a problem hiding this comment.
IMO the emphasis on the YOU should stay. Maybe sth like As with everything in Gekko, the tradebot will make decisions based on strategies, **YOU** select/configure/create.?
|
Fixed @askmike |
greenbigfrog
approved these changes
Dec 13, 2017
|
Awesome, thanks :) |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs Update
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Other information: