Ui changes branch #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arch redesign
Dev - Added linter
Dev - Cropper added
|
can you pull dev into your branch too |
|
I did that. |
cimplesid
requested changes
Oct 11, 2020
|
@nayakastha Check the comments else LGTM |
cimplesid
requested changes
Oct 11, 2020
|
@nayakastha time for final touches 👍 |
cimplesid
reviewed
Oct 11, 2020
|
Final changes.. At least I hope so. |
cimplesid
reviewed
Oct 12, 2020
|
@nayakastha remove that commented code and done |
cimplesid
approved these changes
Oct 12, 2020
|
@nayakastha We would like you to join our Discord server. If you are interested please join the Discord server to discuss more about the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the final PR. Sorry for all the trouble. I hope this is fine. I am closing the previous issue. #20 This is the issue attached