feat: issue opened event #52
Conversation
apps/github/src/@types/index.d.ts
Outdated
| sender: { [key: string]: unknown }; | ||
| repository: { [key: string]: unknown }; | ||
| organization: { [key: string]: unknown }; | ||
| installation: { [key: string]: unknown }; | ||
| [key: string]: unknown; |
There was a problem hiding this comment.
So, we don't know the data type of these properties? As the value is set to unknown.
There was a problem hiding this comment.
This type can be constructed using Record utility type.
so, [key: string]: unknown => Record<string, unknown>
There was a problem hiding this comment.
Github has labelled the type as object so I used unknown.
There was a problem hiding this comment.
This type can be constructed using Record utility type.
so,
[key: string]: unknown=>Record<string, unknown>
Done.
apps/github/src/@types/index.d.ts
Outdated
| body: string | null; | ||
| title: string; |
There was a problem hiding this comment.
If we just need body and title it's okay to define only them although the payload has other props.
There was a problem hiding this comment.
I got this error when I removed the extra props.
| // check if the event is from registered repository | ||
| if ( | ||
| !askBuddieBot.isValidRepository( | ||
| (payload.repository?.name as string) ?? '' |
There was a problem hiding this comment.
This doesn't work?
| (payload.repository?.name as string) ?? '' | |
| payload.repository?.name ?? '' |
There was a problem hiding this comment.
i get this error without typing it as string.
No description provided.