Remove envoy.reloadable_features.grpc_http1_reverse_bridge_change_htt…

…p_status This commit removes the runtime flag introduced in envoyproxy#31047 since it has been 6 months since that change. Signed-off-by: Henry Qin <[email protected]> Signed-off-by: asingh-g <[email protected]>
asingh-g · Aug 20, 2024 · 433e790 · 433e790
1 parent 8280b53
commit 433e790
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/changelogs/current.yaml b/changelogs/current.yaml
@@ -56,6 +56,11 @@ removed_config_or_runtime:
   change: |
     Removed ``envoy.reloadable_features.grpc_http1_reverse_bridge_handle_empty_response`` runtime
     flag and legacy code paths.
+- area: grpc reverse bridge
+  change: |
+    Removed ``envoy.reloadable_features.grpc_http1_reverse_bridge_change_http_status`` runtime flag
+    and legacy code paths.
+
 
 new_features:
 - area: tls

diff --git a/source/common/runtime/runtime_features.cc b/source/common/runtime/runtime_features.cc
@@ -44,7 +44,6 @@ RUNTIME_GUARD(envoy_reloadable_features_enable_compression_bomb_protection);
 RUNTIME_GUARD(envoy_reloadable_features_enable_include_histograms);
 RUNTIME_GUARD(envoy_reloadable_features_exclude_host_in_eds_status_draining);
 RUNTIME_GUARD(envoy_reloadable_features_gcp_authn_use_fixed_url);
-RUNTIME_GUARD(envoy_reloadable_features_grpc_http1_reverse_bridge_change_http_status);
 RUNTIME_GUARD(envoy_reloadable_features_grpc_side_stream_flow_control);
 RUNTIME_GUARD(envoy_reloadable_features_http1_balsa_delay_reset);
 RUNTIME_GUARD(envoy_reloadable_features_http1_balsa_disallow_lone_cr_in_chunk_extension);

diff --git a/source/extensions/filters/http/grpc_http1_reverse_bridge/filter.cc b/source/extensions/filters/http/grpc_http1_reverse_bridge/filter.cc
@@ -9,7 +9,6 @@
 #include "source/common/grpc/status.h"
 #include "source/common/http/headers.h"
 #include "source/common/http/utility.h"
-#include "source/common/runtime/runtime_features.h"
 
 namespace Envoy {
 namespace Extensions {
@@ -182,10 +181,7 @@ Http::FilterHeadersStatus Filter::encodeHeaders(Http::ResponseHeaderMap& headers
     grpc_status_ = grpcStatusFromHeaders(headers);
 
     // gRPC clients expect that the HTTP status will always be 200.
-    if (Runtime::runtimeFeatureEnabled(
-            "envoy.reloadable_features.grpc_http1_reverse_bridge_change_http_status")) {
-      headers.setStatus(enumToInt(Http::Code::OK));
-    }
+    headers.setStatus(enumToInt(Http::Code::OK));
 
     // This is a header-only response, and we should prepend the gRPC frame
     // header directly.