Skip to content
This repository has been archived by the owner on Jul 16, 2024. It is now read-only.

Improved Sidecar and Deployment behavior

Compare
Choose a tag to compare
@tfhartmann tfhartmann released this 16 Mar 17:43
· 10 commits to master since this release
v7.0.0
3300f84
This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Learn about vigilant mode.

This version of the module puts the requirement on the user of the
module to set instances to DRAINING in some fashion. In our case we are
using our sidecar container, which includes a healthcheck which set the
DRAINING State.

updates the sidecar container used.
This keeps this module inline with
FitnessKeeper/terraform-aws-consul-agents

In addition the old version of the module somewhat handled making sure the cluster would survive the instances being cycled under the ASG's by allowing you to span multiple ASG's *and *multiplying the desired task count by two, in this version the desired count is the correct count, so if you ask for a count of 3, you'll get three tasks, and we leave it to another facility to set the instances to draining. In this case, we provide all hooks to do this, but the parameter definitions still needs to be set correctly if you are using the default sidecar container image. The default setting is ["ecs-cluster"] which will correctly configure the sidecar to keep an eye on the instance life cycle state, and set the instance to DRAINING in ECS if the instance starts to terminate.

Assets 2
Loading