Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add restrict to parent class #30

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Conversation

ashley-taylor
Copy link
Owner

No description provided.

Copy link

@SaurabhBose SaurabhBose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Also used Ask Copilot to surface some insights too. :)
"Updated Annotation Retrieval:
Modified the annotation retrieval logic to use the new getAnnotation method from EntityUtil instead of directly calling getAnnotation on the class."

Map<String, List<Object>> responseNoneAllowed = execute(LIST_QUERY_INHERITANCE_GPL, variables).getData();
Assertions.assertEquals(0, responseNoneAllowed.get("listInheritance").size());
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From Ask Copilot which was quite helpful:

listEntityInheritanceQuery:
A new test method listEntityInheritanceQuery is added. This method tests the new LIST_QUERY_INHERITANCE_GPL query with different sets of allowed variables to verify the size of the listInheritance field in the response.
Test Scenarios:
When all values in allowed are true, the size of listInheritance should be 3.
When the values are mixed (true, false, true), the size should be 2.
When all values are false, the size should be 0.
These additions ensure that the inheritance-based restrictions are correctly tested by simulating different scenarios and validating the responses accordingly.

@ashley-taylor ashley-taylor merged commit ac213e7 into master Oct 11, 2024
1 check passed
@ashley-taylor ashley-taylor deleted the restrict-on-parent-class branch October 11, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants