Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes colorlog issue where train.log is saved in project root dir #588

Merged
merged 1 commit into from
Jul 29, 2023

Conversation

tesfaldet
Copy link
Contributor

What does this PR do?

Fixes colorlog issue where train.log (and eval.log) are saved in the project root dir instead of in the correct log dir, i.e., it fixes #396.

Before submitting

  • Did you make sure title is self-explanatory and the description concisely explains the PR?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you test your PR locally with pytest command?
  • Did you run pre-commit hooks with pre-commit run -a command?

Did you have fun?

yep

@tesfaldet
Copy link
Contributor Author

Tests can be fixed by merging this PR #585

@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.09% 🎉

Comparison is base (9355a5d) 83.66% compared to head (2ada6d2) 83.75%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #588      +/-   ##
==========================================
+ Coverage   83.66%   83.75%   +0.09%     
==========================================
  Files          11       11              
  Lines         355      357       +2     
==========================================
+ Hits          297      299       +2     
  Misses         58       58              

see 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@ashleve ashleve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix

.gitignore Outdated Show resolved Hide resolved
@ashleve ashleve added the bug Something isn't working label Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

train.log and eval.log are generated in current work dir
3 participants