more comments and better naming for code readability

ashitsalesforce · Oct 21, 2023 · 929b089 · 929b089
1 parent 5ff702e
commit 929b089
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/src/main/java/com/salesforce/dataloader/client/PartnerClient.java b/src/main/java/com/salesforce/dataloader/client/PartnerClient.java
@@ -810,7 +810,7 @@ public void setFieldReferenceDescribes() throws ConnectionException {
 
                         // make sure that the object is legal to upsert
                         Field[] parentObjectFields = describeSObject(parentObjectName).getFields();
-                        Map<String, Field> parentFieldInfo = new HashMap<String, Field>();
+                        Map<String, Field> parentIdLookupFieldMap = new HashMap<String, Field>();
                         for (Field parentField : parentObjectFields) {
                             if (!parentField.isIdLookup()) {
                                 continue;
@@ -833,12 +833,14 @@ public void setFieldReferenceDescribes() throws ConnectionException {
                                 childObjectField.setLabel(childFieldLabel);
                             } else { // non-Id lookup field on the parent entity
                                 if (haSingleParentObject) {
-                                    parentFieldInfo.put(parentField.getName(), parentField);
+                                    parentIdLookupFieldMap.put(parentField.getName(), parentField);
                                 }
                             }
                         } // for loop
-                        if (!parentFieldInfo.isEmpty()) {
-                            DescribeRefObject describeRelationship = new DescribeRefObject(parentObjectName, childObjectField, parentFieldInfo);
+                        if (!parentIdLookupFieldMap.isEmpty()) {
+                            // A non-empty parentIdLookupFieldMap implies non-polymorphic lookup relationship
+                            // to a parent object that has idLookup fields.
+                            DescribeRefObject describeRelationship = new DescribeRefObject(parentObjectName, childObjectField, parentIdLookupFieldMap);
                             referenceDescribes.put(relationshipName, describeRelationship);
                         }
                     }