Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing protocol scheme in settings menu does not update #17

Closed
jrozner opened this issue Sep 29, 2020 · 1 comment · Fixed by #23
Closed

Changing protocol scheme in settings menu does not update #17

jrozner opened this issue Sep 29, 2020 · 1 comment · Fixed by #23
Labels
bug Something isn't working triage Issue needs triage
Milestone
1.1.1

Comments

@jrozner
Copy link
Member

jrozner commented Sep 29, 2020

Golang version (go version): 1.14.9

OS version (uname -a if on a Unix-like system): macos 10.15.6

Description of the problem including expected versus actual behavior:

Going through the first run and then attempting to change the protocol used (eg. https -> http) for the api url does not update. If a user enters the wrong one when setting up they need to exit the application and change it.

Steps to reproduce:

  1. Start aterm and walk through the setup process using https://localhost:3000
  2. Update config from menus and change from https://localhost:3000 to http://localhost:3000
  3. Attempt to test the connnection
@jrozner jrozner added bug Something isn't working triage Issue needs triage labels Sep 29, 2020
@JoelAtDeluxe
Copy link
Contributor

I think each of the edited values are not being saved.

@JoelAtDeluxe JoelAtDeluxe mentioned this issue Sep 29, 2020
Merged
@jrozner jrozner added this to the 1.1.1 milestone Sep 29, 2020
@jrozner jrozner mentioned this issue Sep 29, 2020
Merged
jrozner added a commit that referenced this issue Sep 29, 2020
@jrozner @JoelAtDeluxe
Fix edit config not saving new values (#18) (#23)
a39f4e5 
Cherry Pick of f6c2209

Fixes #17

Co-authored-by: Joel Smith <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working triage Issue needs triage
Projects
None yet
Milestone
1.1.1
Development

Successfully merging a pull request may close this issue.

Fix edit config not saving new values (#18) ashirt-ops/aterm
2 participants
@jrozner @JoelAtDeluxe