Make bindings resilient to OOM errors #923
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes a relatively simple but maybe controversial change.
In the functions that return a
Vec
, instead of usingVec::with_capacity
and similar, we useVec::new()
followed withVec::try_reserve
. Iftry_reserve
fails, we returnVK_ERROR_OUT_OF_HOST_MEMORY
.Note that there's no shorter way on stable Rust to do this. Notably,
try_with_capacity
is unstable.If I'm not mistaken, the bindings now never panic in case of OOM.
I personally don't have a need for this change, but I thought that this was a neat thing to add.