platform_types: Convert Windows HANDLE types to isize

[MarijnS95]

The windows crate treats these as isize rather than raw void pointers:
https://microsoft.github.io/windows-docs-rs/doc/windows/Win32/Foundation/struct.HWND.html

And raw-window-handle 0.6 recently started to do the same:
rust-windowing/raw-window-handle#136

However, the win32 documentation still states that these should be PVOID:
https://learn.microsoft.com/en-us/windows/win32/winprog/windows-data-types

Hence I'm not super confident what the right step forward is: isize is a breaking change (we'll do a breaking release soon™™™ anyway) but plays more nicely with interop with other crates. @madsmtm was your motivation for raw-window-handle also the type representation in windows-rs?

[Ralith]

This is ABI-compatible, so I see no harm in conforming to the de facto standard.

[madsmtm]

@madsmtm was your motivation for raw-window-handle also the type representation in windows-rs?

Yup, see also discussion in microsoft/windows-rs#1643.

Apologies for not making that change explicitly, I intended to do so but it must have gotten it mixed in with the linked PR.

[MarijnS95]

Thanks @madsmtm, that issue seems rather long and confusing. The TL;DR being that even if a handle may (sometimes?) be a pointer, the user shouldn't be aware of this (and always use appropriate APIs) so an isize to hide that (ignoring the discussion about pointer aliasing rules for the compiler) is appropriate.

I'll go ahead and merge this 👍

[MarijnS95]

As noted in the linked windows-rs by me some time ago, these types changed back to raw pointers once again:

For anyone subscribed to this thread, it looks like the types are changed back to pointers recently:

microsoft/win32metadata#1924
microsoft/win32metadata@b4dfd2f

Looks like this on a regen: microsoft/windows-rs@96b9a27

And related discussion rust-windowing/raw-window-handle#171. It doesn't seem like we should blindly change it back though.