improvement: fix lexical import error in DSL macros

we now only unimport and reimport other DSL extension sections when processing a top level section
ash-project · Jul 27, 2023 · 1382584 · 1382584
1 parent 32f79c7
commit 1382584
Showing 1 changed file with 14 additions and 6 deletions.
diff --git a/lib/spark/dsl/extension.ex b/lib/spark/dsl/extension.ex
@@ -1047,17 +1047,25 @@ defmodule Spark.Dsl.Extension do
             end)
 
           other_extension_unimports =
-            for extension <- Module.get_attribute(__CALLER__.module, :extensions) do
-              quote do
-                import unquote(extension), only: []
+            if unquote(path) == [] do
+              for extension <- Module.get_attribute(__CALLER__.module, :extensions) do
+                quote do
+                  import unquote(extension), only: []
+                end
               end
+            else
+              []
             end
 
           other_extension_reimports =
-            for extension <- Module.get_attribute(__CALLER__.module, :extensions) do
-              quote do
-                import unquote(extension), only: :macros
+            if unquote(path) == [] do
+              for extension <- Module.get_attribute(__CALLER__.module, :extensions) do
+                quote do
+                  import unquote(extension), only: :macros
+                end
               end
+            else
+              []
             end
 
           entity_imports ++