Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation with what Igniter generates #216

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

aifrak
Copy link
Contributor

@aifrak aifrak commented Jul 28, 2024

mix igniter.install ash_json_api generates different code than the ones showed in this guide.

This PR adds the code snippet of what Igniter is generating.

Contributor checklist

  • Bug fixes include regression tests
  • Features include unit/acceptance tests

Comment on lines -38 to -40
config :mime, :types, %{
"application/vnd.api+json" => ["json"]
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This made some errors. The new code is what Igniter generates.

Copy link
Contributor

@zachdaniel zachdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! I think the only thing that hasn't already been addressed is the mime type configuration. Could you remove the other things from the PR? Then I will merge 🙇‍♂️

@aifrak
Copy link
Contributor Author

aifrak commented Jul 29, 2024

I have removed the requested parts.

@zachdaniel zachdaniel merged commit 7633fce into ash-project:main Jul 29, 2024
14 of 15 checks passed
@zachdaniel
Copy link
Contributor

🚀 Thank you for your contribution! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants