Avoid __popcnt64 on MSVC Windows 32-bit platform
#87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
frederick-vs-ja
force-pushed
the
msvc-win32-popcnt
branch
from
3d0c4a6
to
5eea86f
Compare
frederick-vs-ja
force-pushed
the
msvc-win32-popcnt
branch
from
5eea86f
to
87ded4f
Compare
frederick-vs-ja
force-pushed
the
msvc-win32-popcnt
branch
2 times, most recently
from
6b8e567
to
ebb6e97
Compare
|
Gently ping @asg017. Can we merge this? |
The `__popcnt64` intrinsic isn't supported on 32-bit Windows, so `__popcnt` should be used instead.
frederick-vs-ja
force-pushed
the
msvc-win32-popcnt
branch
from
ebb6e97
to
c1f5d03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
__popcnt64intrinsic isn't supported on 32-bit Windows, so__popcntshould be used instead.See also https://learn.microsoft.com/en-us/cpp/intrinsics/popcnt16-popcnt-popcnt64?view=msvc-170.
IMO, ideally we should use
stdc_count_ones(see here and WG14 N3220). But it will take a long long while until C23 will become popular enough.