Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use make-dir instead of mkdirp #26

Merged
merged 1 commit into from
Jul 7, 2017

Conversation

sudo-suhas
Copy link
Collaborator

Switch out mkdirp in favor of make-dir. make-dir is promise ready and does not need to be promisified using bluebird. More advantages here - https://github.com/sindresorhus/make-dir

@sudo-suhas sudo-suhas force-pushed the refactor_switch_to_make-dir branch from 0142010 to 16e7925 Compare July 6, 2017 06:58
@asfktz asfktz merged commit c088a9b into asfktz:master Jul 7, 2017
@sudo-suhas sudo-suhas deleted the refactor_switch_to_make-dir branch July 7, 2017 11:48
@asfktz asfktz added this to the 0.1.0 milestone Jul 9, 2017
@wtgtybhertgeghgtwtg
Copy link
Contributor

Why did this get reverted if make-dir is still in package.json?

@sudo-suhas
Copy link
Collaborator Author

Hey @wtgtybhertgeghgtwtg, thank you for noticing that and bringing it to our attention. I think mkdirp must have been added back by mistake. Would you be interested in submitting a pull request which fixes this? You only need to change src/utils.fs.js, src/validateCache.js and remove mkdirp from package.json.

@asfktz
Copy link
Owner

asfktz commented Dec 22, 2017

Nice 👍 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants