PR-3242 Improve handling of JWT bearer tokens #853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reweeden
force-pushed
the
rew/pr-3242-reduce-edl-calls
branch
5 times, most recently
from
f12c953 to
a1023e9
Compare
gjclark
reviewed
Jan 9, 2025
| except EulaException as e: | ||
| log.warning("user has not accepted EULA") | ||
| status_code = 403 |
There was a problem hiding this comment.
Would it be useful or possible to use http status forbidden from https://docs.python.org/3/library/http.html#http-status-codes?
There was a problem hiding this comment.
It would be possible, I'm not sure it would be super useful. It would be nice to have the text names of the status codes, but then you'd lose the integer code information which is ultimately what matters.
Besides the debate over whether or not it should be changed, procedurally I would want to make a change like that in it's own PR since it would have to touch code all over TEA.
mckadesorensen
approved these changes
Jan 10, 2025
reweeden
force-pushed
the
rew/pr-3242-reduce-edl-calls
branch
from
a1023e9 to
839daec
Compare
reweeden
force-pushed
the
rew/pr-3242-reduce-edl-calls
branch
from
839daec to
7cd5ebb
Compare
mattp0
approved these changes
Jan 10, 2025
reweeden
force-pushed
the
rew/pr-3242-reduce-edl-calls
branch
from
7cd5ebb to
c9ecccb
Compare
mattp0
approved these changes
Jan 10, 2025
reweeden
force-pushed
the
rew/pr-3242-reduce-edl-calls
branch
from
c9ecccb to
d9e2af9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the old bearer token logic with updated handling for JWT bearer tokens. The user_id is extracted from the bearer token directly, eliminating 1 call to EDL, and then the token is used to fetch the user profile, simultaneously verifying the validity of the token and returning the profile information. That eliminates another EDL call for fetching an application bearer token.
TODO: