Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add messages for bulk install visibility #1754

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

StingRayZA
Copy link

Summary

Adds a progress message mentioning that a package is being downloaded and installed. Useful when bulk installing tools to know what is actively happening.

Fixes: #1753

Other Information

@StingRayZA StingRayZA requested a review from a team as a code owner May 10, 2024 15:46
@StingRayZA StingRayZA force-pushed the stingrayza/verbose-batch-install branch from 45258a0 to 83e00a9 Compare May 10, 2024 15:48
@StingRayZA StingRayZA changed the title Add downloading and installing messages feat: Add messages for bulk install visibility May 10, 2024
@StingRayZA
Copy link
Author

@jthegedus apologies for the direct ping, any chance of getting a review, here, please?

@jthegedus
Copy link
Contributor

Some test cases will likely need to be updated.

The Fish issue is unrelated and one I need to resolve.

@StingRayZA
Copy link
Author

Thanks @jthegedus
Let me see if I can get the failing test(s) updated :)

@StingRayZA StingRayZA force-pushed the stingrayza/verbose-batch-install branch from ad4e81c to c402245 Compare October 9, 2024 16:08
@StingRayZA
Copy link
Author

StingRayZA commented Oct 9, 2024

@jthegedus Tests updated (I've rebased my branch on the upstream master - so commit history is clean)

I wasn't able to figure out how to do a multiline match, so I've matched on partial strings. I did add a specific test to separately check for these particular outputs.

Add downloading and installing messages

Signed-off-by: Raimund Hook <[email protected]>
@StingRayZA StingRayZA force-pushed the stingrayza/verbose-batch-install branch from c402245 to f31c639 Compare October 14, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Print a line mentioning what plugin/version is currently being installed
2 participants