Warn macOS users about kerl's supported versions? #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Took me some trail/error/googling to figure this out. Loving `asdf` though! Also wonder, if this seems like a good change, perhaps `asdf-erlang` itself could warn macOS users?
|
Thanks for the PR, and sorry for the late review. I have one comment on the message, but I think this is something we should have in the readme. |
Stratus3D
reviewed
Feb 17, 2021
|
This change seems inaccurate now? I was just able to run: with no issues on macOS Sonoma 14.1.2 (23B2091) on an M3 Max. Or maybe it's the wording that is misleading? Does it mean only version of macOS 10.x.x (not affecting MacOS 11, 12, 13, 14 or newer)? |
|
@kiere good question. @patreeceeo do you know? In any case the readme now needs to be updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Took me some trail/error/googling to figure this out. Loving
asdfthough!Also wonder, if this seems like a good change, perhaps
asdf-erlangitself could warn macOS users?