-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow to install default rust packages #33
base: master
Are you sure you want to change the base?
Conversation
Is this repo, and by extension this PR dead? |
For the repo I cannot say. For the PR, I need to fix some things, but the main feature is present. |
|
…obbing issues The changes made in the script include adding the -r flag to the read command to prevent backslashes from being interpreted as escape characters, and quoting variables to prevent word splitting and globbing issues. This ensures that the script behaves as expected and handles file paths and package names correctly.
Nor the different The handling of the TOML format seems a 'Nice to have' feature, IMHO. |
@smorimoto |
for binary in "$ASDF_INSTALL_PATH/.cargo/bin"/*; do | ||
ln -s "$binary" "$ASDF_INSTALL_PATH/bin/$(basename "$binary")" | ||
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With #32 , the cargo packages are installed directly into this folder, so no need to pass --root
, or symlinking the binaries 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to know, but depends on this PR to be merged, or cherry-picking the modifications or this PR ;)
The purpose of this Pull Request is to mimic the behavior of python or nodejs asdf plugin, and to allow to install default rust packages.
Each package will be installed inside the rust folder.