Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make gmp flag configurable #68

Merged
merged 1 commit into from
Dec 2, 2020
Merged

feat: make gmp flag configurable #68

merged 1 commit into from
Dec 2, 2020

Conversation

susurri
Copy link
Contributor

@susurri susurri commented Nov 29, 2020

make gmp flag configurable with PHP_WITH_GMP.
PHP_WITH_GMP=yes asdf install php will build php with --with-gmp.

@smorimoto smorimoto self-requested a review November 29, 2020 19:30
@smorimoto
Copy link
Member

Is it not enough to just pass a flag to PHP_CONFIGURE_OPTIONS?

@susurri
Copy link
Contributor Author

susurri commented Dec 1, 2020

as --without-gmp is there and additional --with-gmp does not cancel it.

@smorimoto
Copy link
Member

​Ideally, I would like to recommend submitting a patch to fix that behavior upstream, but I will merge this at this moment.

@smorimoto smorimoto merged commit 9b49789 into asdf-community:master Dec 2, 2020
@smorimoto
Copy link
Member

Thanks @susurri!

@smorimoto
Copy link
Member

Also, I think it would be better to mention this in the README. Would you like to work on it?

@IndraGunawan IndraGunawan mentioned this pull request Apr 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smorimoto smorimoto smorimoto approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@susurri @smorimoto