Fixed error `PlayerNames.lua:96: attempt to concatenate field "?" (a …

…nil value)`
ascott18 · Dec 13, 2019 · d7cc677 · d7cc677
1 parent fe6018f
commit d7cc677
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,7 @@
 * Fix #1742 - Errors related to improper escaping of user input for the suggestion list.
 * Fixed error `bad argument #1 to 'strlower' (string expected, got boolean)` when using Diminishing Returns icons
 * Fix #1755 - Swing Timer conditions with durations other than zero seconds were not triggering updates at the proper moment.
+* Fixed error `PlayerNames.lua:96: attempt to concatenate field "?" (a nil value)`
 
 ## v8.7.2
 ### Bug Fixes

diff --git a/Components/Core/Common/PlayerNames.lua b/Components/Core/Common/PlayerNames.lua
@@ -91,8 +91,8 @@ end
 
 function NAMES:UPDATE_BATTLEFIELD_SCORE()
 	for i = 1, GetNumBattlefieldScores() do
-		local name, _, _, _, _, _, _, _, class = GetBattlefieldScore(i)
-		if name and class then -- sometimes this returns nil??
+		local name, _, _, _, _, _, _, _, _, class = GetBattlefieldScore(i)
+		if name and class and self.ClassColors[class] then -- sometimes this returns nil??
 			self.ClassColoredNameCache[name] = self.ClassColors[class] .. name .. "|r"
 		end
 	end

diff --git a/Options/CHANGELOG.lua b/Options/CHANGELOG.lua
@@ -11,6 +11,7 @@ TMW.CHANGELOG = [==[
 * Fix #1742 - Errors related to improper escaping of user input for the suggestion list.
 * Fixed error `bad argument #1 to 'strlower' (string expected, got boolean)` when using Diminishing Returns icons
 * Fix #1755 - Swing Timer conditions with durations other than zero seconds were not triggering updates at the proper moment.
+* Fixed error `PlayerNames.lua:96: attempt to concatenate field "?" (a nil value)`
 
 ## v8.7.2
 ### Bug Fixes

diff --git a/TellMeWhen.lua b/TellMeWhen.lua
@@ -44,7 +44,7 @@ elseif strmatch(projectVersion, "%-%d+%-") then
 end
 
 TELLMEWHEN_VERSION_FULL = TELLMEWHEN_VERSION .. " Classic " .. TELLMEWHEN_VERSION_MINOR
-TELLMEWHEN_VERSIONNUMBER = 87304 -- NEVER DECREASE THIS NUMBER (duh?).  IT IS ALSO ONLY INTERNAL (for versioning of)
+TELLMEWHEN_VERSIONNUMBER = 87305 -- NEVER DECREASE THIS NUMBER (duh?).  IT IS ALSO ONLY INTERNAL (for versioning of)
 
 TELLMEWHEN_FORCECHANGELOG = 86005 -- if the user hasn't seen the changelog until at least this version, show it to them.