Skip to content

Commit

Permalink
fix: #2191
Browse files Browse the repository at this point in the history
  • Loading branch information
ascott18 committed Sep 7, 2024
1 parent 2170cf6 commit 39e87ee
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 15 deletions.
5 changes: 3 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
## v11.0.7
* #1857 - Add LibCustomGlow animations.
* Fix: #2191 - Icon Shown condition ignoring Shown/Hidden checkboxes for disabled icons/groups.
* Fix: #2193 - Icon overlay and border animations starting in the wrong state.
* Fix: #2215 - Spell Charges condition not updating for countable spells without true charges.
* Fix: #2217 - Error in item cooldown conditions
* Fix: #2220 - GCD state not ending when GCD ends.
* Fix: #2219 - Prevent cooldown finish pulse from showing on hidden icons
* Fix: #2193 - Icon overlay and border animations starting in the wrong state.
* Fix: #2220 - GCD state not ending when GCD ends.

## v11.0.6
* #2190: Added options to Buff/Debuff icons to source stack count from tooltip numbers.
Expand Down
19 changes: 8 additions & 11 deletions Components/Core/Conditions/Categories/Misc.lua
Original file line number Diff line number Diff line change
Expand Up @@ -59,20 +59,17 @@ ConditionCategory:RegisterCondition(1, "ICON", {
unit = false,
icon = "Interface\\Icons\\INV_Misc_PocketWatch_01",
tcoords = CNDT.COMMON.standardtcoords,
funcstr = function(c, icon)
if c.Icon == "" or c.Icon == icon:GetGUID() then
--return [[true]]
Env = {
IsIconShown = function(icon)
if not icon or not icon.attributes.shown then return false end
icon:Update()
return icon.attributes.realAlpha > 0
end

},
funcstr = function(c, icon)
TMW:QueueValidityCheck(icon, c.Icon, L["VALIDITY_CONDITION_DESC"])

local str = [[( c.Icon and c.Icon.attributes.shown and not c.Icon:Update())]]
if c.Level == 0 then
str = str .. [[and c.Icon.attributes.realAlpha > 0]]
else
str = str .. [[and c.Icon.attributes.realAlpha == 0]]
end
return str
return "BOOLCHECK(IsIconShown(c.Icon))"
end,
--[[events = function(ConditionObject, c)
local event = TMW.Classes.IconDataProcessor.ProcessorsByName.REALALPHA.changedEvent
Expand Down
5 changes: 3 additions & 2 deletions Options/CHANGELOG.lua
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,12 @@ TMW.CHANGELOG_LASTVER="10.0.0"
TMW.CHANGELOG = [==[
## v11.0.7
* #1857 - Add LibCustomGlow animations.
* Fix: #2191 - Icon Shown condition ignoring Shown/Hidden checkboxes for disabled icons/groups.
* Fix: #2193 - Icon overlay and border animations starting in the wrong state.
* Fix: #2215 - Spell Charges condition not updating for countable spells without true charges.
* Fix: #2217 - Error in item cooldown conditions
* Fix: #2220 - GCD state not ending when GCD ends.
* Fix: #2219 - Prevent cooldown finish pulse from showing on hidden icons
* Fix: #2193 - Icon overlay and border animations starting in the wrong state.
* Fix: #2220 - GCD state not ending when GCD ends.
## v11.0.6
* #2190: Added options to Buff/Debuff icons to source stack count from tooltip numbers.
Expand Down

0 comments on commit 39e87ee

Please sign in to comment.