refactor: リポジトリをNode 16+/npm 8+へ変更 #1464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for js-primer ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
azu
commented
Aug 21, 2022
| @@ -1,28 +0,0 @@ | |||
| // LICENSE : MIT | |||
| "use strict"; | |||
| const tester = require("text-testing-mocha"); | |||
There was a problem hiding this comment.
このテストはメンテされてないのでいいかなと思ったので消した。依存的に古いから
package.json
Outdated
| @@ -47,26 +47,27 @@ | |||
| "gitbook", | |||
| "textlint" | |||
| ], | |||
| "workspaces": ["textlint/*"], | |||
There was a problem hiding this comment.
textlintルールはworkspaceで入れる。
| @@ -2,5 +2,5 @@ | |||
| publish = "_book" | |||
| command = "npm run build" | |||
| [build.environment] | |||
| NODE_VERSION = "14" | |||
| NODE_VERSION = "16" | |||
| @@ -76,7 +76,7 @@ ${message}`); | |||
| it("prototypeメソッドの説明をする前にObject#methodの表記を利用してはいけない", () => { | |||
| // 許可リスト(読み方の解説など) | |||
| const allowFilePathList = []; | |||
| const searchPatterns = ["/\\`[a-zA-Z]+#[a-zA-Z]*\\`/"]; | |||
| const searchPatterns = ["/`[a-zA-Z]+#[a-zA-Z]*`/"]; | |||
There was a problem hiding this comment.
unicodeオプションが作るのでescapeがエラーになった
| @@ -12,7 +12,7 @@ | |||
| "scripts": { | |||
| "test": "mocha \"./final/final/test/*.js\"", | |||
| "e2e": "start-server-and-test start http://localhost:3000/README.md cy:run", | |||
| "start": "npx @js-primer/local-server --port 3000", | |||
| "start": "npx -y @js-primer/local-server --port 3000", | |||
There was a problem hiding this comment.
npxはデフォルトだとインストールはしないので、
azu
commented
Aug 21, 2022
| @@ -1,833 +0,0 @@ | |||
| #!/bin/sh | |||
There was a problem hiding this comment.
多分pdfとかをローカルで作ってた時のかも。今はいらない。
azu
commented
Aug 21, 2022
Comment on lines
+8
to
+30
|
|
||
| /** | ||
| * ESMのeampleを評価するテスト | ||
| * Note: ESMには対応していない | ||
| **/ | ||
| describe("example:es", function() { | ||
| const esmFiles = globby.sync([ | ||
| `${sourceDir}/use-case/todoapp/**/*-example.js`, // *-example.js | ||
| `${sourceDir}/use-case/todoapp/**/*.example.js`, // *.example.js | ||
| ]); | ||
| esmFiles.forEach(filePath => { | ||
| const normalizeFilePath = filePath.replace(sourceDir, ""); | ||
| // TODO: doctestはしていないで、読み込んでOKかどうかだけ | ||
| it(`example:es ${normalizeFilePath}`, function() { | ||
| return import(filePath).catch(error => { | ||
| // Stack Trace like | ||
| console.error(`Dynamic Eval is failed | ||
| at doctest (${filePath}:1:1)`); | ||
| return Promise.reject(error); | ||
| }); | ||
| }); | ||
| }) | ||
| }); |
There was a problem hiding this comment.
vm2はESMをサポートしてないので、dynamic importを使って評価する形にした。
.exampleとは別の名前にした方いいかもしれない。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1463