Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upstream build is using github.event.client_payload.branch incorrectly #1050

Closed
mojavelinux opened this issue Aug 2, 2021 · 0 comments · Fixed by #1051
Closed

Upstream build is using github.event.client_payload.branch incorrectly #1050

mojavelinux opened this issue Aug 2, 2021 · 0 comments · Fixed by #1051

Comments

@mojavelinux
Copy link
Member

The configuration for the upstream build is using the value of github.event.client_payload.branch to look for a reference in its own repository. This is incorrect. It should clone the branch for which the CI job was triggered (which is the default behavior of the checkout action). Then, it should use the value of github.event.client_payload.branch in ./test-asciidoctor-upstream.sh to get the right branch of Asciidoctor core to build against.
mojavelinux added a commit to mojavelinux/asciidoctorj that referenced this issue Aug 2, 2021
@mojavelinux
resolves asciidoctor#1050 fix upstream build to build against the spe…
a13c3fb 
…cified ref
mojavelinux added a commit to mojavelinux/asciidoctorj that referenced this issue Aug 3, 2021
@mojavelinux
resolves asciidoctor#1050 fix upstream build to build against the spe…
ae9cf42 
…cified ref
@mojavelinux mojavelinux mentioned this issue Aug 3, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

resolves #1050 fix upstream build to build against the specified ref mojavelinux/asciidoctorj
1 participant
@mojavelinux