-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Include directive" topic is included twice :) #565
Comments
Uh oh. That was probably as a result of an improperly resolved merge conflict. Of course, that raises the question, where should it go. Surprisingly, I think the answer is neither of those locations. I think the most logic place for it is in the part "Structuring, Navigating, and Referencing Your Content". Want to do a PR? |
Sure, I think the related PR is #506 but I didn't understand exactly the goal so I wasn't sure that this was intended or not... |
Definitely an accident. We had quite a few merge conflicts in that series of changes, so it's understandable why it happened. |
Ok.
I agree but as the the time we should introduce the include macro before: http://asciidoctor.org/docs/user-manual/#include-partial (30.4).
I think "Basics", "File resolution" and maybe "AsciiDoc vs non-AsciiDoc files" should go before "30.4. Select Portions of a Document to Include". "Partitioning large documents and using leveloffset" could go in the part "Structuring, Navigating, and Referencing Your Content". @mojavelinux @rockyallen What do you think ? |
As of today it looks like:
Agreed that 31.3, 31.5 and 31.9 are all about organizing content in large documents, but I think they should be kept with the include topic if possible. Maybe regroup as:
? |
The duplicate has been removed. However, we haven't done any restructuring. Should we still do that? |
Chapter 31 and chapter 51:
http://asciidoctor.org/docs/user-manual/#include-directive-2
http://asciidoctor.org/docs/user-manual/#include-directive
Not sure if this is intended but we have id duplication on section titles
include-partitioning
,include-nonasciidoc
...The text was updated successfully, but these errors were encountered: