Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use esbuild to produce a single file #506

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ggrossetie
Copy link
Member

@ggrossetie ggrossetie commented Feb 2, 2022

  • Upgrade target from es6 to es2020 (to reduce bundle size)
  • Upgrade minimum VS code version to 1.60.0

TODO

  • make sure that localization is still working when using a single file

resolves #491

@ggrossetie ggrossetie force-pushed the esbuild branch 3 times, most recently from 10b3fea to 89c2806 Compare February 6, 2022 10:51
@ggrossetie ggrossetie mentioned this pull request Feb 6, 2022
@ggrossetie
Copy link
Member Author

Currently, the bundle size is 2.8mb.
I didn't notice any performance improvement on desktop but esbuild is pretty fast and hopefully the tree shaking will eventually decrease the bundle size.

We might also want to use esbuild to bundle the web extension (in a follow-up pull request) as, currently, Webpack produces a 3.6mb bundle. Alternatively, we could try to tune Webpack. For reference, the current configuration is heavily inspired by: https://github.com/microsoft/vscode/blob/main/extensions/markdown-language-features/extension.webpack.config.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use target es2020 and minimum version to 1.56 to reduce bundle size
1 participant