Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce code style via linter (part of #446) #448

Merged
merged 15 commits into from
Sep 26, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
*/test/*
/test/*
.eslintrc.js
/dist/*
12 changes: 8 additions & 4 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ module.exports = {
"tsconfigRootDir": __dirname,
"sourceType": "module"
},
"plugins": ["@typescript-eslint"],
"extends": [
// "eslint:recommended",
// "plugin:@typescript-eslint/recommended",
"standard"
],
"rules": {
"arrow-parens": ["error", "always"],
Expand All @@ -25,6 +25,10 @@ module.exports = {
"ignoreTemplateLiterals": true
}],
//"indent": ["error", 4],
"spaced-comment": "off"
"semi": ["error", "never"],
"spaced-comment": "off",
// https://github.com/typescript-eslint/typescript-eslint/issues/2621
"no-unused-vars": "off",
"@typescript-eslint/no-unused-vars": ["error", { argsIgnorePattern: "^_" }],
}
};
};
12 changes: 9 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
name: Lint and Compile

on: [push]
on:
push:
branches:
- master
pull_request:
branches:
- '*'

jobs:
build:
Expand All @@ -10,9 +16,9 @@ jobs:
steps:
- uses: actions/checkout@v2
- name: Use Node.js
uses: actions/setup-node@v1
uses: actions/setup-node@v2
with:
node-version: '12.x'
node-version: '14'
- run: npm ci
- run: npm run lint
- run: npm run compile
Expand Down
Loading