-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix preview opening relative link #400
Conversation
Is there anything I can do to help with the preview process? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this contribution and your patience with the review process.
This PR doesn't currently pass an npm lint
but the fix is easy. If we could remove extraneous commented code that would be good (this repo already suffers from an overdose of that) and I think the additional task is not required.
If you agree could you please make the modifications.
All should be resolved |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't set up linting myself (not familiar with node.js), but I think that is all changes.
Is there something I still need to do? It still says Changes requested. Not sure if I need to confirm something somewhere. |
LGTM, thanks @rongcuid for these changes and for this improvement. @joaompinto if you have the time could we have a release pelase? (Incidentally I plan to to do some work on this extension and winter is soon approaching which will provide more time -- there are several other deprecations which will probably bite soon). |
@danyill I have been a bit inactive lately, the release to marketplace is automated, you just need to create a new tag and push it, do you want to try it ? |
A little scary but yes that worked beautifully, thanks 😄 |
Fixes #397. I haven't tested very comprehensively, but I tried a few common cases (that I encounter).