Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contributing guide misses a prerequisites section #655

Closed
ahus1 opened this issue Nov 6, 2022 · 0 comments · Fixed by #656
Closed

Contributing guide misses a prerequisites section #655

ahus1 opened this issue Nov 6, 2022 · 0 comments · Fixed by #656
Labels
💬 discussion Disccussion on new features, projects, etc... ✨ enhancement

Comments

@ahus1
Copy link
Contributor

ahus1 commented Nov 6, 2022

When reading the CONTRIBUTING.adoc file, I found that is misses a prerequisite section.

It also misses an npm install.

I'll prepare a PR for this.
@ahus1 ahus1 added ✨ enhancement 💬 discussion Disccussion on new features, projects, etc... labels Nov 6, 2022
ahus1 added a commit to ahus1/asciidoctor-vscode that referenced this issue Nov 6, 2022
@ahus1
Add an introduction and a prerequisite section.
946dc64 
Also add the `npm install` command.

Closes asciidoctor#655
@ahus1 ahus1 mentioned this issue Nov 6, 2022
Merged
ggrossetie pushed a commit that referenced this issue Nov 6, 2022
@ahus1
Add an introduction and a prerequisite section. (#656)
09fabd2 
resolves #655
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💬 discussion Disccussion on new features, projects, etc... ✨ enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add an introduction and a prerequisite section. ahus1/asciidoctor-vscode
1 participant
@ahus1