Implemented subtitle partitioning #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code taken from Bespoke converter with minor changes
|
Looks good. I noticed that you brought in a couple of functions you aren't yet using. Future use? |
|
Hahaha no, it's a mistake. I'll remove it. |
|
Done and applied author and preamble CSS classes to the relevant sections as a bonus. |
|
👍 I don't think you need to say where the constants and functions come from. That's useful for the PR but probably not long-term. However, you could say at the top that this is similar to the Bespoke converter so that developers get the cue to study that converter as a reference (and vice versa). |
obilodeau
added a commit
to obilodeau/asciidoctor-reveal.js
that referenced
this pull request
Sep 29, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #70. Removed unnecessary HTML tags if no authors are provided too.