Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data-state to slides #61

Merged
merged 1 commit into from
Oct 3, 2016
Merged

Add data-state to slides #61

merged 1 commit into from
Oct 3, 2016

Conversation

nipafx
Copy link
Contributor

@nipafx nipafx commented Mar 10, 2016

Reveal.js has the concept of slide states, where a slide's value for data-state will be applied to the document as a CSS class. With this it is easy to, e.g. give selected slides a distinct style.

The reaveal.js backend does currently not set the state. With the change proposed here, the following works:

[data-state="empty"]
=== !

Which leads to

<section data-state="empty" class="present"></section>

I did not thoroughly check whether this change should also be applied to one of the other templates.

@obilodeau
Copy link
Member

With changes proposed in #52 data-state should become state in the asciidoc markup. The data- prefix is more typing and is an artifact of reveal.js' HTML5 roots.

[state="empty"]
=== !

Aside than that: looking good! All that is missing is the documentation (and maybe a CSS style example would be nice).

@nipafx
Copy link
Contributor Author

nipafx commented Mar 19, 2016

data-state vs state

Good point. But #52 is not merged yet. We could wait for that and I will then update this PR. Or we go the other way around, merge this and then update #52. Whatever you prefer. 😄

Documentation

Should I include this in the README or do you have other documentation in mind?

@obilodeau
Copy link
Member

You are right. We can merge this first.

Documentation: End user documentation in the readme. In it point to reveal
feature description and give an example. Bonus points if your example is
also in test/

Thanks!

On Sat, Mar 19, 2016, 2:38 AM Nicolai Parlog [email protected]
wrote:

data-state vs state

Good point. But #52
#52 is not
merged yet. We could wait for that and I will then update this PR. Or we go
the other way around, merge this and then update #52
#52. Whatever
you prefer. [image: 😄]
Documentation

Should I include this in the README or do you have other documentation in
mind?


You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#61 (comment)

@obilodeau
Copy link
Member

Still waiting on the documentation.

@obilodeau
Copy link
Member

#52 was merged. I'll merge your branch, adjust it to #52's changes, I'll write a quick README entry and test case.

Just giving you a last opportunity to do it yourself if you want to. Let me know.

@nipafx
Copy link
Contributor Author

nipafx commented Sep 7, 2016

Hi @obilodeau, sorry, I missed the previous message. If you're up for doing it, that would be great.

@nipafx
Copy link
Contributor Author

nipafx commented Oct 3, 2016

Great work, can't wait to find this in the next release. :)

@nipafx
Copy link
Contributor Author

nipafx commented Oct 3, 2016

Oh wait, this was the asciidoctor project without releases. Nevermind...

@obilodeau
Copy link
Member

Continuous releases 😉

@nipafx nipafx deleted the nipa branch July 22, 2018 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants