(main) Use Maven Eclipse Sisu to inject components #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abelsromero
changed the title
abelsromero
force-pushed
the
branch-main/issue-945/use-eclipse-sisu-for-di
branch
from
183f125 to
441f989
Compare
abelsromero
force-pushed
the
branch-main/issue-945/use-eclipse-sisu-for-di
branch
from
6ba6adb to
a92cabc
Compare
Use profile to allow to modify dependencies and properties in a central point
…return only '<asciidoc>' configuration always
abelsromero
force-pushed
the
branch-main/issue-945/use-eclipse-sisu-for-di
branch
from
d78dc28 to
020d7d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a pull request and contributing to asciidoctor-maven-plugin!
What kind of change does this PR introduce? (check at least one)
What is the goal of this pull request?
Use Eclipse Sisu for dependency injection to better organize code. We have been using manual instance creation and that's limiting how modular we can make the code (TLDR; it's easier to create static method helper classes or private methods than cohesive components).
This has already allowed some simple refactors (more to come), and reduce usage of reflection for testing.
Notes:
Logto methods for simplicity. With Maven 4 that will be removed in favor of normal slf4j.Are there any alternative ways to implement this?
Still experimenting.
Are there any implications of this pull request? Anything a user must know?
No, changes are transparent to users.
Is it related to an existing issue?
#945