(main) Use latest maven-plugin-tools #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maven Plugin Tools is a set of tools (plugin, dependencies) to generate metadata required for the Maven plugin. As such, we can run the latest and use Dependabot to automate the management without issues. We still have CI tests to validate backward compatibility
abelsromero
force-pushed
the
use-latest-maven-plugin-tools
branch
from
fa4a99e to
e832581
Compare
abelsromero
added a commit
to abelsromero/asciidoctor-maven-plugin
that referenced
this pull request
Jan 1, 2024
Similar to PR asciidoctor#717, to ease project maintenance we can automate Doxia dependencies and use CI to validate backward compatibility.
8 tasks
abelsromero
added a commit
to abelsromero/asciidoctor-maven-plugin
that referenced
this pull request
Jan 1, 2024
Similar to PR asciidoctor#717, to ease project maintenance we can automate Doxia dependencies and use CI to validate backward compatibility.
abelsromero
added a commit
to abelsromero/asciidoctor-maven-plugin
that referenced
this pull request
Jan 1, 2024
Similar to PR asciidoctor#717, to ease project maintenance we can automate Doxia dependencies and use CI to validate backward compatibility.
abelsromero
added a commit
that referenced
this pull request
Jan 1, 2024
* Similar to PR #717, to ease project maintenance we can automate Doxia dependencies and use CI to validate backward compatibility. * Move Doxia properties to parent pom
abelsromero
added a commit
to abelsromero/asciidoctor-maven-plugin
that referenced
this pull request
Jan 1, 2024
Similar to PRs asciidoctor#717 and asciidoctor#719, to ease project maintenance we can automate Maven (core and transitives) dependencies and use CI to validate backward compatibility. * Deleted direct references to dependencies that are provided by maven-core: ideally we'd like to refer them if we use them, but ther lack of a BOM make it un-practical. * Rename build properties for ease of use.
abelsromero
added a commit
to abelsromero/asciidoctor-maven-plugin
that referenced
this pull request
Jan 1, 2024
Similar to PRs asciidoctor#717 and asciidoctor#719, to ease project maintenance we can automate Maven (core and transitives) dependencies and use CI to validate backward compatibility. * Remove maven exclusion from Dependabot. * Deleted direct references to dependencies that are provided by maven-core: ideally we'd like to refer them if we use them, but ther lack of a BOM make it un-practical. * Rename build properties for ease of use. * Fix mising 'url' in 'asciidoctor-parser-doxia-module' module.
abelsromero
added a commit
to abelsromero/asciidoctor-maven-plugin
that referenced
this pull request
Jan 1, 2024
Similar to PRs asciidoctor#717 and asciidoctor#719, to ease project maintenance we can automate Maven (core and transitives) dependencies and use CI to validate backward compatibility. * Remove maven exclusion from Dependabot. * Deleted direct references to dependencies that are provided by maven-core: ideally we'd like to refer them if we use them, but ther lack of a BOM make it un-practical. * Rename build properties for ease of use. * Fix mising 'url' in 'asciidoctor-parser-doxia-module' module.
8 tasks
abelsromero
added a commit
to abelsromero/asciidoctor-maven-plugin
that referenced
this pull request
Jan 1, 2024
Similar to PRs asciidoctor#717 and asciidoctor#719, to ease project maintenance we can automate Maven (core and transitives) dependencies and use CI to validate backward compatibility. * Remove maven exclusion from Dependabot. * Deleted direct references to dependencies that are provided by maven-core: ideally we'd like to refer them if we use them, but ther lack of a BOM make it un-practical. * Rename build properties for ease of use. * Fix mising 'url' in 'asciidoctor-parser-doxia-module' module.
abelsromero
added a commit
that referenced
this pull request
Jan 1, 2024
Similar to PRs #717 and #719, to ease project maintenance we can automate Maven (core and transitives) dependencies and use CI to validate backward compatibility. * Remove maven exclusion from Dependabot. * Deleted direct references to dependencies that are provided by maven-core: ideally we'd like to refer them if we use them, but ther lack of a BOM make it un-practical. * Rename build properties for ease of use. * Fix mising 'url' in 'asciidoctor-parser-doxia-module' module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
What is the goal of this pull request?
Maven Plugin Tools is a set of tools (plugin, dependencies) to generate metadata required for the Maven plugin. As such, we can run the latest and use Dependabot to automate the management without issues.
We still have CI tests to validate backward compatibility.
Are there any alternative ways to implement this?
Keep using a pinned older version, however that means we cannot use Dependabot. So we depend on manual action to update from time to time.
Since we have CI to test multiple Maven versions I don't think it makes sense to keep this "use older version" policy.
There will be other similar PRs like this for other dependencies.
Are there any implications of this pull request? Anything a user must know?
no
Is it related to an existing issue?
Finally, please add a corresponding entry to CHANGELOG.adoc