Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IT for maven-site-plugin v3.10.0 #641

Merged

Conversation

abelsromero
Copy link
Member

@abelsromero abelsromero commented May 27, 2023

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Documentation
  • Refactor
  • Build improvement
  • Other (please describe)

What is the goal of this pull request?

This new test validates the minimal maven-site-plugin supported version.

Are there any alternative ways to implement this?

We could somehow parametrize the version and run the IT's twice, but that seems a lot of work.
In the long run, I'd like to have an extension similar to what we do in the maven examples to run end-to-end tests more easily and quicker.

Are there any implications of this pull request? Anything a user must know?
no

Is it related to an existing issue?

  • Yes
  • No

Finally, please add a corresponding entry to CHANGELOG.adoc

@abelsromero abelsromero force-pushed the add-maven-site-v.3.10.0-it branch from db929b9 to fe242f3 Compare May 27, 2023 20:55
@abelsromero abelsromero force-pushed the add-maven-site-v.3.10.0-it branch from fe242f3 to f8a05fe Compare May 27, 2023 21:44
This tests validates the minimal maven-site-plugin
supported version
@abelsromero abelsromero merged commit ba780ef into asciidoctor:v2.2.x May 27, 2023
@abelsromero abelsromero deleted the add-maven-site-v.3.10.0-it branch December 28, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant